Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set src attribute for verific with full info #3943

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Set src attribute for verific with full info #3943

merged 1 commit into from
Sep 19, 2023
+1 −1

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Sep 19, 2023

This makes src attribute completely same as in Yosys verilog frontend and gives full information about source position.

Location for Yosys verilog frontent is created here :
https://github.com/YosysHQ/yosys/blob/master/frontends/ast/ast.cc#L985

@nakengelhardt
Copy link
Member

Thanks! src attribute format has caused issues with mcy in the past, can you check that mcy (and mcy-gui) still runs fine with this? I expect it will since it's the same format as read_verilog, but best to make sure.

@mmicko mmicko merged commit 8fb807c into master Sep 19, 2023
@mmicko mmicko deleted the verific_lineinfo branch September 19, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakengelhardt nakengelhardt nakengelhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmicko @nakengelhardt